[EXT] Re: [PATCH v6 5/5] arm64: dts: freescale: add support for i.MX8DXL EVK board

[Shawn Guo]

On Tue, Sep 06, 2022 at 01:15:37PM +0000, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo at kernel.org>
> > Sent: Friday, September 2, 2022 10:48 PM
> > To: Shenwei Wang <shenwei.wang at nxp.com>
> > Cc: Rob Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt at linaro.org>; Sascha Hauer <s.hauer at pengutronix.de>;
> > Pengutronix Kernel Team <kernel at pengutronix.de>; Peng Fan
> > <peng.fan at nxp.com>; devicetree at vger.kernel.org; linux-arm-
> > kernel at lists.infradead.org; imx at lists.linux.dev; dl-linux-imx <linux-
> > imx at nxp.com>
> > Subject: [EXT] Re: [PATCH v6 5/5] arm64: dts: freescale: add support for
> > i.MX8DXL EVK board
> > 
> > > +             regulator-always-on;
> > > +     };
> > > +
> > > +     reg_fec1_sel: regulator-1 {
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "fec1_supply";
> > > +             regulator-min-microvolt = <3300000>;
> > > +             regulator-max-microvolt = <3300000>;
> > > +             gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>;
> > 
> > Missing enable-active-high?
> 
> No. Enabling this regulator to select the fec1 interface instead of usdhc2. Pulling this GPIO pin to low is to use FEC1 interface. 

Then the polarity cell should be GPIO_ACTIVE_LOW rather than
GPIO_ACTIVE_HIGH?

Shawn