[PATCH linux-next] PCI: iproc: Remove the unneeded result variable

Florian Fainelli f.fainelli at gmail.com
Tue Sep 6 14:37:47 PDT 2022



On 9/6/2022 2:27 PM, Scott Branden wrote:
> 
> 
> On 2022-09-06 14:25, Bjorn Helgaas wrote:
>> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte at gmail.com wrote:
>>> From: ye xingchen <ye.xingchen at zte.com.cn>
>>>
>>> Return the value iproc_pcie_setup_ib() directly instead of storing it in
>>> another redundant variable.
>>>
>>> Reported-by: Zeal Robot <zealci at zte.com.cn>
>>> Signed-off-by: ye xingchen <ye.xingchen at zte.com.cn>
>>
>> This patch itself is fine,
> Does the patch serve any real use though?

Not really though if we don't accept it, then someone else will submit a 
similar patch later, since it is obviously correct, might as well accept it?
-- 
Florian



More information about the linux-arm-kernel mailing list