[PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver

Shawn Guo shawnguo at kernel.org
Mon Sep 5 19:09:17 PDT 2022


On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
> > > +struct imx93_blk_ctrl_data {
> > > +	const struct imx93_blk_ctrl_domain_data *domains;
> > > +	const struct imx93_blk_ctrl_domain_data *bus;
> > 
> > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data.  I
> > would suggest you have 'related' fields directly defined in
> > imx93_blk_ctrl_data.
> 
> This would implies a bit large change to this driver.
> 
> Should I use a new V1 for the patchset or continue V9 for next version?

I think v9 is fine.

Shawn



More information about the linux-arm-kernel mailing list