[PATCH v1 4/8] gpiolib: Get rid of ARCH_NR_GPIOS
Nuno Sá
noname.nuno at gmail.com
Fri Sep 2 04:39:43 PDT 2022
On Fri, 2022-09-02 at 13:52 +0300, Andy Shevchenko wrote:
> (Nuno, one point below for you)
>
> On Wed, Aug 31, 2022 at 11:55 PM Arnd Bergmann <arnd at arndb.de> wrote:
>
> ...
>
> > drivers/gpio/gpio-adp5520.c: gc->base = pdata->gpio_start; //
> > unused
> > drivers/gpio/gpio-adp5588.c: gc->base = pdata-
> > >gpio_start; // unused
> > drivers/input/keyboard/adp5588-keys.c: kpad->gc.base = gpio_data-
> > >gpio_start; // unused
> > drivers/input/keyboard/adp5589-keys.c: kpad->gc.base = gpio_data-
> > >gpio_start; // unused
>
> I believe we should convert them to -1.
>
Well, the adp5588-keys.c was already refactored [1] to use FW
properties so that -1 will be used. In the process, gpio-adp5588.c
was dropped.
For the adp5589-keys.c driver, we might also need to do a similar
work as I suspect there's no platform making use of pdata. Hence,
yes, I believe -1 is the way to go.
Ditto for gpio-adp5520.c...
[1]:
https://lore.kernel.org/linux-input/Yw7hRIbsTqOWVeyJ@google.com/T/#m382bec5c587241010d453ce1000bea2d34b86380
- Nuno Sá
>
More information about the linux-arm-kernel
mailing list