[EXT] Re: [PATCH v5 1/2] net: phylink: add mac_managed_pm in phylink_config structure

[Shenwei Wang]

> -----Original Message-----
> From: Florian Fainelli <f.fainelli at gmail.com>
> Sent: Thursday, October 13, 2022 1:48 PM
> On 10/13/22 06:39, Shenwei Wang wrote:
> > The recent commit
> >
> > 'commit 47ac7b2f6a1f ("net: phy: Warn about incorrect
> > mdio_bus_phy_resume() state")'
> >
> > requires the MAC driver explicitly tell the phy driver who is managing
> > the PM, otherwise you will see warning during resume stage.
> >
> > Add a boolean property in the phylink_config structure so that the MAC
> > driver can use it to tell the PHY driver if it wants to manage the PM.
> >
> > 'Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> > mdio_bus_phy_resume() state")'
> 
> This is not the way to provide a Fixse tag, it should simply be:
> 
> Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> mdio_bus_phy_resume() state"
> 

That was my original format. But it met the following warning when ran checkpatch.pl script:

./scripts/checkpatch.pl 0001-net-phylink-add-mac_managed_pm-in-phylink_config-str.patch 
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: e6a39ffcfe22 ("net: stmmac: Enable mac_managed_pm phylink config")'
#20: 
Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect

That's why I changed to the current tag format.

Regards,
Shenwei

> With that fixed:
> 
> Acked-by: Florian Fainelli <f.fainelli at gmail.com>
> 
> as a courtesy, you could CC the author of the patch you are fixing BTW
> --
> Florian