[xilinx-xlnx:xlnx_rebase_v5.15_LTS_2022.1_update 629/1102] drivers/gpu/drm/xlnx/xlnx_dsi.c:967:41: warning: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from 200000000000 to 2431504384
kernel test robot
lkp at intel.com
Mon May 30 23:52:48 PDT 2022
Hi Saurabh,
FYI, the error/warning still remains.
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS_2022.1_update
head: 8e42834c82e505bacccca3c9d35da7041793d9d7
commit: 32f4c7d25b52562567b652709480223cf36e3229 [629/1102] drm: xlnx: dsi: Adding dsi driver to new framework
config: arm-randconfig-r026-20220531 (https://download.01.org/0day-ci/archive/20220531/202205311412.m96mKuN1-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c825abd6b0198fb088d9752f556a70705bc99dfd)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/Xilinx/linux-xlnx/commit/32f4c7d25b52562567b652709480223cf36e3229
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15_LTS_2022.1_update
git checkout 32f4c7d25b52562567b652709480223cf36e3229
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/xlnx/ drivers/media/i2c/ drivers/staging/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/xlnx/xlnx_dsi.c:967:41: warning: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from 200000000000 to 2431504384 [-Wconstant-conversion]
ret = clk_set_rate(dsi->dphy_clk_200M, XDSI_DPHY_CLK_REQ);
~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/xlnx/xlnx_dsi.c:88:27: note: expanded from macro 'XDSI_DPHY_CLK_REQ'
#define XDSI_DPHY_CLK_REQ 200000000000UL
^~~~~~~~~~~~~~
>> drivers/gpu/drm/xlnx/xlnx_dsi.c:980:39: warning: result of comparison of constant 203000000000 with expression of type 'unsigned long' is always false [-Wtautological-constant-out-of-range-compare]
if (rate < XDSI_DPHY_CLK_MIN && rate > XDSI_DPHY_CLK_MAX) {
~~~~ ^ ~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/xlnx/xlnx_dsi.c:980:11: warning: result of comparison of constant 197000000000 with expression of type 'unsigned long' is always true [-Wtautological-constant-out-of-range-compare]
if (rate < XDSI_DPHY_CLK_MIN && rate > XDSI_DPHY_CLK_MAX) {
~~~~ ^ ~~~~~~~~~~~~~~~~~
3 warnings generated.
vim +967 drivers/gpu/drm/xlnx/xlnx_dsi.c
928
929 static int xlnx_dsi_probe(struct platform_device *pdev)
930 {
931 struct device *dev = &pdev->dev;
932 struct resource *res;
933 struct xlnx_dsi *dsi;
934 struct device_node *vpss_node;
935 int ret;
936 unsigned long rate;
937
938 dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
939 if (!dsi)
940 return -ENOMEM;
941
942 dsi->dsi_host.ops = &xlnx_dsi_ops;
943 dsi->dsi_host.dev = dev;
944 dsi->dev = dev;
945
946 ret = xlnx_dsi_parse_dt(dsi);
947 if (ret)
948 return ret;
949
950 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
951 dsi->iomem = devm_ioremap_resource(dev, res);
952 if (IS_ERR(dsi->iomem))
953 return PTR_ERR(dsi->iomem);
954
955 platform_set_drvdata(pdev, dsi);
956
957 /* Bridge support */
958 vpss_node = of_parse_phandle(dsi->dev->of_node, "xlnx,vpss", 0);
959 if (vpss_node) {
960 dsi->bridge = of_xlnx_bridge_get(vpss_node);
961 if (!dsi->bridge) {
962 dev_info(dsi->dev, "Didn't get bridge instance\n");
963 return -EPROBE_DEFER;
964 }
965 }
966
> 967 ret = clk_set_rate(dsi->dphy_clk_200M, XDSI_DPHY_CLK_REQ);
968 if (ret) {
969 dev_err(dev, "failed to set dphy clk rate %d\n", ret);
970 return ret;
971 }
972
973 ret = clk_prepare_enable(dsi->dphy_clk_200M);
974 if (ret) {
975 dev_err(dev, "failed to enable dphy clk %d\n", ret);
976 return ret;
977 }
978
979 rate = clk_get_rate(dsi->dphy_clk_200M);
> 980 if (rate < XDSI_DPHY_CLK_MIN && rate > XDSI_DPHY_CLK_MAX) {
981 dev_err(dev, "Error DPHY clock = %lu\n", rate);
982 ret = -EINVAL;
983 goto err_disable_dphy_clk;
984 }
985
986 ret = clk_prepare_enable(dsi->video_aclk);
987 if (ret) {
988 dev_err(dev, "failed to enable video clk %d\n", ret);
989 goto err_disable_dphy_clk;
990 }
991
992 ret = component_add(dev, &xlnx_dsi_component_ops);
993 if (ret < 0)
994 goto err_disable_video_clk;
995
996 return ret;
997
998 err_disable_video_clk:
999 clk_disable_unprepare(dsi->video_aclk);
1000 err_disable_dphy_clk:
1001 clk_disable_unprepare(dsi->dphy_clk_200M);
1002 return ret;
1003 }
1004
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the linux-arm-kernel
mailing list