[PATCH] perf cs-etm: Use swap() instead of open coding it
Jiapeng Chong
jiapeng.chong at linux.alibaba.com
Fri May 6 02:17:18 PDT 2022
Clean the following coccicheck warning:
./tools/perf/util/cs-etm.c:418:34-35: WARNING opportunity for swap().
Reported-by: Abaci Robot <abaci at linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
---
tools/perf/util/cs-etm.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 8b95fb3c4d7b..0cb555cc766f 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -406,18 +406,13 @@ struct cs_etm_packet_queue
static void cs_etm__packet_swap(struct cs_etm_auxtrace *etm,
struct cs_etm_traceid_queue *tidq)
{
- struct cs_etm_packet *tmp;
-
if (etm->synth_opts.branches || etm->synth_opts.last_branch ||
- etm->synth_opts.instructions) {
+ etm->synth_opts.instructions)
/*
* Swap PACKET with PREV_PACKET: PACKET becomes PREV_PACKET for
* the next incoming packet.
*/
- tmp = tidq->packet;
- tidq->packet = tidq->prev_packet;
- tidq->prev_packet = tmp;
- }
+ swap(tidq->packet, tidq->prev_packet);
}
static void cs_etm__packet_dump(const char *pkt_string)
--
2.20.1.7.g153144c
More information about the linux-arm-kernel
mailing list