[PATCH v2 0/6] Make evlist CPUs more accurate
Ian Rogers
irogers at google.com
Mon Mar 28 16:26:42 PDT 2022
evlist has all_cpus, computed to be the merge of all evsel CPU maps,
and cpus. cpus may contain more CPUs than all_cpus, as by default cpus
holds all online CPUs whilst all_cpus holds the merge/union from
evsels. For an uncore event there may just be 1 CPU per socket, which
will be a far smaller CPU map than all online CPUs.
These patches change cpus to be called user_requested_cpus, to reflect
their potential user specified nature. The user_requested_cpus are set
to be the current value intersected with all_cpus, so that
user_requested_cpus is always a subset of all_cpus. This fixes
printing code for metrics so that unnecessary blank lines aren't
printed.
To make the intersect function perform well, a perf_cpu_map__is_subset
function is added. While adding this function, also use it in
perf_cpu_map__merge to avoid creating a new CPU map for some currently
missed patterns.
v2. Reorders the "Avoid segv" patch and makes other adjustments
suggested by Arnaldo Carvalho de Melo <acme at kernel.org>.
Ian Rogers (6):
perf stat: Avoid segv if core.user_cpus isn't set.
perf evlist: Rename cpus to user_requested_cpus
perf cpumap: Add is_subset function
perf cpumap: More cpu map reuse by merge.
perf cpumap: Add intersect function.
perf evlist: Respect all_cpus when setting user_requested_cpus
tools/lib/perf/cpumap.c | 73 ++++++++++++++++++++----
tools/lib/perf/evlist.c | 28 ++++-----
tools/lib/perf/include/internal/cpumap.h | 1 +
tools/lib/perf/include/internal/evlist.h | 7 ++-
tools/lib/perf/include/perf/cpumap.h | 2 +
tools/perf/arch/arm/util/cs-etm.c | 8 +--
tools/perf/arch/arm64/util/arm-spe.c | 2 +-
tools/perf/arch/x86/util/intel-bts.c | 2 +-
tools/perf/arch/x86/util/intel-pt.c | 4 +-
tools/perf/bench/evlist-open-close.c | 2 +-
tools/perf/builtin-ftrace.c | 2 +-
tools/perf/builtin-record.c | 6 +-
tools/perf/builtin-stat.c | 11 ++--
tools/perf/builtin-top.c | 2 +-
tools/perf/util/auxtrace.c | 2 +-
tools/perf/util/bpf_ftrace.c | 4 +-
tools/perf/util/evlist.c | 17 +++---
tools/perf/util/record.c | 6 +-
tools/perf/util/sideband_evlist.c | 3 +-
tools/perf/util/stat-display.c | 2 +-
tools/perf/util/synthetic-events.c | 2 +-
tools/perf/util/top.c | 8 ++-
22 files changed, 132 insertions(+), 62 deletions(-)
--
2.35.1.1021.g381101b075-goog
More information about the linux-arm-kernel
mailing list