[PATCH v18 3/8] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a

[Geert Uytterhoeven]

Hi Alistair,

On Mon, Jan 24, 2022 at 1:24 PM Alistair Francis <alistair at alistair23.me> wrote:
> Signed-off-by: Alistair Francis <alistair at alistair23.me>
> Acked-for-MFD-by: Lee Jones <lee.jones at linaro.org>

> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -62,8 +62,19 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
>         return ret;
>  }
>
> +static const struct mfd_cell sy7636a_cells[] = {
> +       { .name = "sy7636a-regulator", },
> +       { .name = "sy7636a-temperature", },
> +};
> +
> +static const struct simple_mfd_data silergy_sy7636a = {
> +       .mfd_cell = sy7636a_cells,
> +       .mfd_cell_size = ARRAY_SIZE(sy7636a_cells),
> +};
> +
>  static const struct of_device_id simple_mfd_i2c_of_match[] = {
>         { .compatible = "kontron,sl28cpld" },
> +       { .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
>         {}
>  };

This is slowly turning into a "board file" for an ever-growing random
bunch of devices, none of which is described in the help text?

See also my reply to patch 2/8
https://lore.kernel.org/all/CAMuHMdVy4E1pX+VLLq_05FX4pM+BPZycQgn68ArGh2s8qL24=w@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds