[PATCH 0/2] arm64 defconfig: Get faddr2line working
John Garry
john.garry at huawei.com
Thu Jul 28 01:06:55 PDT 2022
trim list
On 25/07/2022 13:51, Arnd Bergmann wrote:
>>> CONFIG_SLIMBUS=m
>> Config 5bd773242f75 added a kconfig "imply" on config SLIMBUS from
>> config SOUNDWIRE_QCOM, and this happens to mean that we don't explicitly
>> require config SLIMBUS enabled in the defconfig.
> That 'imply' looks like it was added to solve a problem using the old 'imply'
> semantics that are not what this keyword does today. I suspect it's still
> broken when CONFIG=SOUNDWIRE_QCOM=y and CONFIG_SLIBMUS=m,
> and the correct fix is to use a dependency like
>
> depends on SLIMBUS || !SLIMBUS
>
> so the defconfig symbol should stay.
>
JFYI, building for CONFIG_SOUNDWIRE_QCOM=y and CONFIG_SLIBMUS=m is ok.
The driver has a runtime check for CONFIG_SLIMBUS in qcom_swrm_probe().
That implementation seems consistent with guidance in
kconfig-language.rst - so do you think that there is still a problem?
thanks,
John
More information about the linux-arm-kernel
mailing list