[PATCH] dmaengine: qcom: hidma_mgmt: Remove redundant 'child' assignment.

Liang He windhl at 126.com
Fri Jul 8 02:47:07 PDT 2022


In hidma_mgmt_of_populate_channels(), 'new_pdev->dev.of_node = child;'
is not needed as it has been correctly done in
platform_device_register_full().

Fixes: 9da0be80be6e ("dmaengine: qcom_hidma: configure DMA and MSI for OF")
Signed-off-by: Liang He <windhl at 126.com>
---
 drivers/dma/qcom/hidma_mgmt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index 62026607f3f8..4655b15f93ff 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
@@ -387,7 +387,6 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
 			ret = PTR_ERR(new_pdev);
 			goto out;
 		}
-		new_pdev->dev.of_node = child;
 		of_dma_configure(&new_pdev->dev, child, true);
 		/*
 		 * It is assumed that calling of_msi_configure is safe on
-- 
2.25.1




More information about the linux-arm-kernel mailing list