[PATCH v4 12/13] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

Andy Shevchenko andy.shevchenko at gmail.com
Mon Jul 4 14:05:22 PDT 2022


On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu <peterwu.pub at gmail.com> wrote:

> Add Mediatek MT6370 flashlight support.

...

> +         This driver can also be built as a module. If so the module

If so,

> +         will be called "leds-mt6370-flash.ko".

No ".ko" part.

...

> +#define MT6370_ITORCH_MINUA            25000
> +#define MT6370_ITORCH_STEPUA           12500
> +#define MT6370_ITORCH_MAXUA            400000
> +#define MT6370_ITORCH_DOUBLE_MAXUA     800000
> +#define MT6370_ISTRB_MINUA             50000
> +#define MT6370_ISTRB_STEPUA            12500
> +#define MT6370_ISTRB_MAXUA             1500000
> +#define MT6370_ISTRB_DOUBLE_MAXUA      3000000
> +#define MT6370_STRBTO_MINUS            64000
> +#define MT6370_STRBTO_STEPUS           32000
> +#define MT6370_STRBTO_MAXUS            2432000

Make units suffix visible, i.e. _US, _uA, etc.

...

> +       if (curr)
> +               val |= MT6370_TORCHEN_MASK;
> +
> +

One blank line is enough.

...

> +       /*
> +        * Due to the current spike when turning on flash,
> +        * let brightness to be kept by framework.

brightness be
the framework

> +        * This empty function is used to
> +        * prevent led_classdev_flash register ops check failure.
> +        */

...

> +       } else {
> +               ret = regmap_update_bits(priv->regmap,
> +                                        MT6370_REG_FLEDISTRB(led->led_no),
> +                                        MT6370_ISTROBE_MASK, val);

> +               if (ret)
> +                       return ret;

Dup of the below.

> +       }
> +       return ret;

...

> +       /*
> +        * If the flash need to be on,
> +        * config the flash current ramping up to the setting value
> +        * Else, always recover back to the minimum one

Missed periods.

> +        */

...

> +       /*
> +        * For the flash turn on/off, HW ramping up/down time is 5ms/500us
> +        * respectively.
> +        */
> +       if (!prev && curr)
> +               usleep_range(5000, 6000);
> +       else if (prev && !curr)
> +               udelay(500);

Comment doesn't explain why this is suddenly a busy loop operation?


> +static int mt6370_led_register(struct device *parent, struct mt6370_led *led,
> +                               struct led_init_data *init_data)
> +{
> +       struct v4l2_flash_config v4l2_config = {0};
> +       int ret;
> +
> +       ret = devm_led_classdev_flash_register_ext(parent, &led->flash,
> +                                                  init_data);
> +       if (ret) {
> +               dev_err(parent, "Couldn't register flash %d\n", led->led_no);
> +               return ret;
> +       }
> +
> +       mt6370_init_v4l2_flash_config(led, &v4l2_config);
> +       led->v4l2_flash = v4l2_flash_init(parent, init_data->fwnode,
> +                                         &led->flash, &v4l2_flash_ops,
> +                                         &v4l2_config);
> +       if (IS_ERR(led->v4l2_flash)) {
> +               dev_err(parent, "Failed to register %d v4l2 sd\n", led->led_no);
> +               return PTR_ERR(led->v4l2_flash);
> +       }
> +
> +       return 0;
> +}

...

> +       } else
> +               val = clamp_align(val, MT6370_STRBTO_MINUS, MT6370_STRBTO_MAXUS,
> +                                 MT6370_STRBTO_STEPUS);

Missed {}

> +
> +

One blank line is enough.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list