[EXTERNAL] Re: [PATCH v2] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu Dec 22 04:33:43 PST 2022


On 22/12/2022 13:13, Bhavya Kapoor wrote:
> 
> On 22/12/22 17:32, Krzysztof Kozlowski wrote:
>> On 21/12/2022 06:51, Bhavya Kapoor wrote:
>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>> for 8 channel ADCs for J721s2 SoC.
>>>
>>> Signed-off-by: Bhavya Kapoor <b-kapoor at ti.com>
>>> ---
>>>
>>> Changelog v1 -> v2:
>>> 	- Updated Interrupt Values for tscadc
>>>
>>>   .../dts/ti/k3-j721s2-common-proc-board.dts    | 14 +++++++
>>>   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     | 42 ++++++++++++++++++-
>>>   2 files changed, 55 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> index a7aa6cf08acd..67593aa69327 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>   	pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>   	phys = <&transceiver2>;
>>>   };
>>> +
>>> +&tscadc0 {
>>> +	status = "okay";
>>> +	adc {
>>> +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> +	};
>>> +};
>>> +
>>> +&tscadc1 {
>>> +	status = "okay";
>>> +	adc {
>>> +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> +	};
>>> +};
>>> \ No newline at end of file
>> Same errors as before.
>>
>> I don't know how many same patches we need to see - this is fourth. None
>> of them seems to be correct...
>>
>> Best regards,
>> Krzysztof
>>
> This is a v2 patch. Please read the changelog. Link to its v1 is 
> https://lore.kernel.org/all/20221220101249.46450-1-b-kapoor@ti.com/

Sure, you still need to correct patch error. I am writing about this
fourth time and you never responded.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list