[PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings

Goh, Wei Sheng wei.sheng.goh at intel.com
Mon Dec 5 20:05:43 PST 2022


Hi,

> -----Original Message-----
> From: Russell King <linux at armlinux.org.uk>
> Sent: Saturday, 3 December, 2022 1:24 AM
> To: Goh, Wei Sheng <wei.sheng.goh at intel.com>
> Cc: Lobakin, Alexandr <alexandr.lobakin at intel.com>; Giuseppe Cavallaro
> <peppe.cavallaro at st.com>; Alexandre Torgue <alexandre.torgue at st.com>;
> Jose Abreu <joabreu at synopsys.com>; David S . Miller
> <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub
> Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Maxime
> Coquelin <mcoquelin.stm32 at gmail.com>; netdev at vger.kernel.org; linux-
> stm32 at st-md-mailman.stormreply.com; linux-arm-
> kernel at lists.infradead.org; linux-kernel at vger.kernel.org; Alexandre Torgue
> <alexandre.torgue at foss.st.com>; Ong, Boon Leong
> <boon.leong.ong at intel.com>; Voon, Weifeng <weifeng.voon at intel.com>;
> Tan, Tee Min <tee.min.tan at intel.com>; Ahmad Tarmizi, Noor Azura
> <noor.azura.ahmad.tarmizi at intel.com>; Looi, Hong Aun
> <hong.aun.looi at intel.com>
> Subject: Re: [PATCH net v4] net: stmmac: Set MAC's flow control register to
> reflect current settings
> 
> On Mon, Nov 28, 2022 at 06:06:11AM +0000, Goh, Wei Sheng wrote:
> > Hi,
> >
> > > -----Original Message-----
> > > From: Lobakin, Alexandr <alexandr.lobakin at intel.com> Any particular
> > > reason why you completely ignored by review comments to the v3[0]?
> > > I'd like to see them fixed or at least replied.
> > >
> > > [0] https://lore.kernel.org/netdev/20221123180947.488302-1-
> > > alexandr.lobakin at intel.com
> > >
> > > Thanks,
> > > Olek
> >
> > Due to v4 is being accepted. Therefore I will submit a new patch to address
> your review comments.
> > Thanks and appreciate your effort for reviewing my patch.
> 
> And on that very same subject, why did you ignore my review comments on
> v2?
> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Sorry I missed some of your comment. Will try to address them in the next submission.
Also thanks and appreciate your effort for reviewing my patch.



More information about the linux-arm-kernel mailing list