[PATCH] ARM: versatile: Add missing of_node_put in dcscb_init

Linus Walleij linus.walleij at linaro.org
Thu Apr 28 16:03:56 PDT 2022


From: Peng Wu <wupeng58 at huawei.com>

The device_node pointer is returned by of_find_compatible_node
with refcount incremented. We should use of_node_put() to avoid
the refcount leak.

Signed-off-by: Peng Wu <wupeng58 at huawei.com>
Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
---
Hi SoC folks, please apply this patch directly, I have
no other planned Versatile changes for v5.19.
---
 arch/arm/mach-versatile/dcscb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-versatile/dcscb.c b/arch/arm/mach-versatile/dcscb.c
index 866270e7f271..d8797350996d 100644
--- a/arch/arm/mach-versatile/dcscb.c
+++ b/arch/arm/mach-versatile/dcscb.c
@@ -144,6 +144,7 @@ static int __init dcscb_init(void)
 	if (!node)
 		return -ENODEV;
 	dcscb_base = of_iomap(node, 0);
+	of_node_put(node);
 	if (!dcscb_base)
 		return -EADDRNOTAVAIL;
 	cfg = readl_relaxed(dcscb_base + DCS_CFG_R);
-- 
2.35.1




More information about the linux-arm-kernel mailing list