[PATCH] irqchip/stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested

Marc Zyngier maz at kernel.org
Fri Apr 22 03:08:24 PDT 2022


On Fri, 22 Apr 2022 10:20:36 +0100,
Fabien DESSENNE <fabien.dessenne at foss.st.com> wrote:
> 
> Hi Marek,
> 
> I agree there is something wrong with the clock management in IRQ
> context here and your patch goes in the right way.
> There are also some other problems regarding performance (enabling /
> disabling clock each time we want to change the IO value, ...).
> For these both issues I have a patch, which basically keeps the GPIO
> clocks enabled from probe.
> I did not have time to submit it, but, considering your concerns, I
> will do it in the coming days.
> For the time being I suggest that we do not apply your patch.

Why? This fixes a glaring issue, and there are no alternatives at the
moment. So if there is something to improve on, please base your patch
on top of Marek's.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list