[PATCH] rtc: ftrtc010: Fix error handling in ftrtc010_rtc_probe

Linus Walleij linus.walleij at linaro.org
Tue Apr 19 15:55:18 PDT 2022


On Sun, Apr 3, 2022 at 7:49 AM Miaoqian Lin <linmq006 at gmail.com> wrote:

> In the error handling path, the clk_prepare_enable() function
> call should be balanced by a corresponding 'clk_disable_unprepare()'
> call , as already done in the remove function.
>
> clk_disable_unprepare calls clk_disable() and clk_unprepare().
> They will use IS_ERR_OR_NULL to check the argument.
>
> Fixes: ac05fba39cc5 ("rtc: gemini: Add optional clock handling")
> Signed-off-by: Miaoqian Lin <linmq006 at gmail.com>

Looks correct!
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list