[PATCH 2/2] arm: dts: Add device tree for bosch acc board

Krzysztof Kozlowski krzk at kernel.org
Tue Apr 12 04:10:29 PDT 2022


On 12/04/2022 12:19, Philip Oberfichtner wrote:
> Add device tree for the Bosch ACC board, based on i.MX6 Dual.
> 

Thank you for your patch. There is something to discuss/improve.

> +	};
> +
> +	backlight {
> +		status = "okay";

Are you overriding any node? Looks like not, so status is not needed.

> +
> +		compatible = "pwm-backlight";
> +		/* The last value is the PWM period in nano-seconds!
> +		 * -> 5 kHz = 200 µS = 200.000 ns
> +		 */
> +		pwms = <&pwm1 0 200000>;
> +		brightness-levels = <0 61 499 1706 4079 8022 13938 22237 33328 47623 65535>;
> +		num-interpolated-steps = <10>;
> +		default-brightness-level = <60>;
> +		power-supply = <&reg_lcd0_pwr>;
> +	};
> +
> +	usb3503_refclk: usb3503_refclk {

hyphens in node names, not underscores. Node names should be generic,
but if you need a specific prefix, it's ok.

> +		compatible = "fixed-factor-clock";
> +		#clock-cells = <0>;
> +
> +		clocks = <&clks IMX6QDL_CLK_CKO2>;
> +		clock-div = <1>;
> +		clock-mult = <1>;
> +		clock-output-names = "12mhz_refclk";
> +
> +		assigned-clocks = <&clks IMX6QDL_CLK_CKO>,
> +				  <&clks IMX6QDL_CLK_CKO2>,
> +				  <&clks IMX6QDL_CLK_CKO2_SEL>;
> +		assigned-clock-parents = <&clks IMX6QDL_CLK_CKO2>,
> +					 <&clks IMX6QDL_CLK_CKO2_PODF>,
> +					 <&clks IMX6QDL_CLK_OSC>;
> +		assigned-clock-rates = <0>, <12000000>, <0>;
> +	};
> +
> +	cpus {
> +		/* Override operating points with board-specific values */
> +		cpu0: cpu at 0 {
> +			operating-points = <

Anything blocking from using OPP v2 bindings?

> +				/* kHz    uV */
> +				1200000 1275000
> +				996000  1225000
> +				852000  1225000
> +				792000  1150000
> +				396000  950000
> +			>;
> +			fsl,soc-operating-points = <

This seems undocumented and actually - why do you need it if you have
generic operating points?

> +				/* ARM kHz  SOC-PU uV */
> +				1200000 1225000
> +				996000	1175000
> +				852000	1175000
> +				792000	1150000
> +				396000	1150000
> +			>;
> +		};
> +
> +		cpu1: cpu at 1 {
> +			operating-points = <
> +				/* kHz    uV */
> +				1200000 1275000
> +				996000  1225000
> +				852000  1225000
> +				792000  1150000
> +				396000  950000
> +			>;
> +			fsl,soc-operating-points = <
> +				/* ARM kHz  SOC-PU uV */
> +				1200000 1225000
> +				996000	1175000
> +				852000	1175000
> +				792000	1150000
> +				396000	1150000
> +			>;
> +		};
> +	};
> +
> +	leds {
> +		compatible = "pwm-leds";
> +
> +		led_red: red {

Generic node names, so led-0.

Add common properties for color and function.

> +			label = "red";
> +			max-brightness = <248>;
> +			default-state = "off";
> +			pwms = <&pwm2 0 500000>;
> +		};
> +
> +		led_white: white {

The same.

> +			label = "white";
> +			max-brightness = <248>;
> +			default-state = "off";
> +			pwms = <&pwm3 0 500000>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +
> +	memory {
> +		reg = <0x10000000 0x40000000>;
> +	};
> +
> +	regulators: regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;

This should not be a bus. Instead "regulator-0" and so on.

> +
> +		supply_5P0: regulator at 0 {
> +			compatible = "regulator-fixed";
> +			reg = <0>;

Please run `make dtbs_check` (see Docs for this) and fix the warnings.
Please fix automated check warnings before using reviewers time.

> +			regulator-name = "5P0";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			regulator-always-on;

Why do you need it? There is no control here, it's only used as a supply
for other uncontrollable regulators (unless I missed something).

> +		};
> +
> +		supply_VIN: regulator at 1 {
> +			compatible = "regulator-fixed";
> +			reg = <1>;
> +			regulator-name = "VIN";
> +			regulator-min-microvolt = <4500000>;
> +			regulator-max-microvolt = <4500000>;
> +			regulator-always-on;
> +			vin-supply = <&supply_5P0>;
> +		};
> +
> +		reg_usb_otg_vbus: regulator at 2 {
> +			compatible = "regulator-fixed";
> +			reg = <2>;
> +			regulator-name = "usb_otg_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +		};
> +
> +		reg_usb_h1_vbus: regulator at 3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
> +			regulator-name = "usb_h1_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			regulator-always-on;
> +			vin-supply = <&supply_5P0>;
> +		};
> +
> +		supply_VSNVS_3V0: regulator at 4 {
> +			compatible = "regulator-fixed";
> +			reg = <4>;
> +			regulator-name = "VSNVS_3V0";
> +			regulator-min-microvolt = <3000000>;
> +			regulator-max-microvolt = <3000000>;
> +			regulator-always-on;
> +			vin-supply = <&supply_5P0>;
> +		};
> +
> +		reg_lcd0_pwr: regulator-lcd0-pwr {
> +			compatible = "regulator-fixed";
> +			regulator-name = "LCD0 POWER";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_lcd_enable>;
> +			gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> +			enable-active-high;
> +			regulator-boot-on;
> +		};
> +
> +		reg_usb_h2_vbus: regulator at 6 {
> +			compatible = "regulator-fixed";
> +			reg = <6>;
> +			regulator-name = "usb_h2_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			vin-supply = <&supply_5P0> ;
> +			regulator-always-on;
> +		};
> +
> +		supply_vref_dac: vref_dac {

1. No underscores in node names.
2. Did you compile dts with W=1 and fixed warnings?


> +			compatible = "regulator-fixed";
> +			regulator-name = "vref_dac";
> +			regulator-min-microvolt = <20000>;
> +			regulator-max-microvolt = <20000>;
> +			vin-supply = <&supply_5P0> ;
> +			regulator-boot-on;
> +		};
> +	};
> +
> +	reset_gpio_led {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_reset_gpio_led>;
> +
> +		reset {
> +			label = "red_reset";
> +			gpios = <&gpio5 18 0>;
> +			default-state = "off";
> +		};
> +	};
> +
> +	soc {
> +		aips1: bus at 2000000 {};
> +	};
> +};
> +
> +&reg_arm {
> +	vin-supply = <&pmic_sw2>;
> +};
> +
> +&reg_soc {
> +	vin-supply = <&pmic_sw1abc>;
> +};
> +
> +&reg_vdd1p1 {
> +	vin-supply = <&supply_VSNVS_3V0>;
> +};
> +
> +&reg_vdd2p5 {
> +	vin-supply = <&supply_VSNVS_3V0>;
> +};
> +
> +&reg_vdd3p0 {
> +	vin-supply = <&supply_VSNVS_3V0>;
> +};
> +
> +&audmux {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_audmux>;
> +	status = "okay";
> +};
> +
> +&fec {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet>;
> +	status = "okay";
> +
> +	clocks = <&clks IMX6QDL_CLK_ENET>,
> +		<&clks IMX6QDL_CLK_ENET>,
> +		<&clks IMX6QDL_CLK_ENET>,
> +		<&clks IMX6QDL_CLK_ENET_REF>;
> +	clock-names = "ipg", "ahb", "ptp", "enet_out";
> +	phy-mode = "rmii";
> +	phy-supply = <&supply_sw4_3V3>;
> +	phy-handle = <&ethphy>;
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		ethphy: ethernet-phy at 0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";
> +			reg = <0>;
> +			interrupt-parent = <&gpio1>;
> +			interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
> +			smsc,disable-energy-detect;
> +		};
> +	};
> +};
> +
> +

No need for two blank lines.

> +&gpu_vg {
> +	status = "disabled";
> +};
> +
> +&gpu_2d {
> +	status = "disabled";
> +};
> +
> +&i2c1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	clock-frequency = <400000>;
> +	status = "okay";
> +
> +	eeprom: eeprom at 50 {
> +		compatible = "atmel,24c32";
> +		reg = <0x50>;
> +		pagesize = <32>;
> +		bytelen = <4096>;
> +		bus-id = <0>;
> +		flags = <0x80>;		/* AT24_FLAG_ADDR16 */
> +	};
> +
> +	lm75: lm75 at 49 {

Generic node name.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_lm75>;
> +
> +		compatible = "national,lm75b";
> +		reg = <0x49>;
> +
> +		interrupts = <7 0x4>;
> +		interrupt-parent = <&gpio4>;
> +	};
> +
> +	pmic: pfuze100 at 8 {

pmic, not pfuze

> +		compatible = "fsl,pfuze100";
> +		reg = <0x08>;
> +		uboot,bootcounter;

Do not add undocumented properties. Please check all entire DTS for such
undocumented stuff.

> +
> +		VGEN1-supply = <&supply_AUX_3V15>;
> +		VGEN2-supply = <&supply_AUX_3V15>;
> +		VGEN3-supply = <&supply_sw4_3V3>;
> +		VGEN4-supply = <&supply_sw4_3V3>;
> +		VGEN5-supply = <&supply_SYS_4V2>;
> +		VGEN6-supply = <&supply_SYS_4V2>;
> +
> +		VREFDDR-supply = <&supply_DDR_1V5>;
> +
> +		SW1AB-supply = <&supply_SYS_4V2>;
> +		SW1C-supply = <&supply_SYS_4V2>;
> +		SW2-supply = <&supply_SYS_4V2>;
> +		SW3A-supply = <&supply_SYS_4V2>;
> +		SW3B-supply = <&supply_SYS_4V2>;
> +		SW4-supply = <&supply_SYS_4V2>;
> +
> +		regulators {
> +			/*
> +			 * VDD_CORE is connected to SW1 ABC
> +			 * We need to define sw1ab and sw1c, but later it is controlled solely with
> +			 * sw1c and therefore only this is named "VDD_SOC".
> +			 * See PMIC datasheet Rev. 18, chapter 6.4.4.3.1: "The feedback and all
> +			 * other controls are accomplished by use of pin SW1CFB and SW1C control
> +			 * registers, respectively."
> +			 * Setting min and max according to SOC datasheet
> +			 */
> +			pmic_sw1abc: sw1c {
> +				regulator-name = "VDD_SOC (sw1abc)";
> +				regulator-min-microvolt = <1275000>;
> +				regulator-max-microvolt = <1500000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +
> +				default-voltage = <1300000>;
> +			};
> +
> +			pmic_sw2: sw2{

Missing space.

> +				regulator-name = "VDD_ARM (sw2)";
> +

Why blank line here and not in other places?

> +				regulator-min-microvolt = <1050000>;
> +				regulator-max-microvolt = <1500000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +
> +				default-voltage = <1300000>;
> +			};
> +
> +			pmic_sw3a: sw3a {
> +				/* U-Boot sets correct voltage, shall not be touched by the OS */
> +				compatible = "regulator-fixed";
> +				regulator-name = "DDR_1V5a";
> +				regulator-boot-on;
> +				regulator-always-on;
> +
> +			};
> +
> +			supply_DDR_1V5: sw3b {
> +				/* U-Boot sets correct voltage, shall not be touched by the OS */
> +				compatible = "regulator-fixed";
> +				regulator-name = "DDR_1V5b";
> +				regulator-boot-on;
> +				regulator-always-on;
> +
> +			};
> +
> +			supply_AUX_3V15: sw4 {
> +				regulator-name = "AUX 3V15 (sw4)";
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <3300000>;
> +
> +				default-voltage = <3150000>;
> +
> +			};
> +
> +			swbst_reg: swbst {
> +				status = "disabled";
> +				regulator-min-microvolt = <5000000>;
> +				regulator-max-microvolt = <5150000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +
> +			};
> +
> +			snvs_reg: vsnvs {
> +				regulator-min-microvolt = <1200000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +
> +				default-voltage = <3000000>;
> +			};
> +
> +			vref_reg: vrefddr {
> +				regulator-boot-on;
> +				regulator-always-on;
> +
> +				default-voltage = <675000>;
> +			};
> +
> +			vgen1_reg: vgen1 {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <1550000>;
> +				regulator-always-on;
> +
> +				default-voltage = <1500000>;
> +			};
> +
> +			vgen2_reg: vgen2 {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <1550000>;
> +				regulator-always-on;
> +
> +				default-voltage = <1200000>;
> +			};
> +
> +			vgen3_reg: vgen3 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +
> +				default-voltage = <2500000>;
> +			};
> +
> +			vgen4_reg: vgen4 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +
> +				default-voltage = <1800000>;
> +			};
> +
> +			vgen5_reg: vgen5 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +
> +				default-voltage = <2800000>;
> +			};
> +
> +			vgen6_reg: vgen6 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +
> +				default-voltage = <2800000>;
> +			};
> +
> +		};
> +	};
> +
> +	rtc: rtcpcf8563 at 51 {

Generic node names.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_rtc>;
> +
> +		compatible = "nxp,pcf8563";
> +		reg = <0x51>;
> +	};
> +};
> +
> +&i2c2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	adc101c: ac101c at 54 {

Ugh...

> +		compatible = "ti,adc101c";
> +		reg = <0x54>;
> +		status = "okay";
> +		vref-supply = <&supply_vref_dac>;
> +		vcc-supply = <&supply_vref_dac>;
> +	};
> +
> +	ad5602: ad5602 at c {
> +		compatible = "adi,ad5602";
> +		reg = <0x0c>;
> +		status = "okay";
> +		vcc-supply = <&supply_vref_dac>;
> +	};
> +
> +	eeprom_ext: eeprom_ext at 50 {

Generic node names, no underscores in node names.

OK, I'll stop for now. :)


Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list