[PATCH 2/3] irqchip: SigmaStar SSD20xD gpi

[Linus Walleij]

On Thu, Sep 30, 2021 at 3:37 PM Daniel Palmer <daniel at 0x0f.com> wrote:
> On Thu, 30 Sept 2021 at 22:06, Marc Zyngier <maz at kernel.org> wrote:
> > No, this is the right spot if you really need to set the handler. But
> > it should really be after the parent allocation (see below for
> > something totally untested).
>
> Your change resolves the null pointer difference when enabling the
> interrupt but when it triggers the below happens.
> This might just be my driver so I'll try to debug.

To me this looks like your IRQ handler is firing for unused IRQs, i.e.
you are getting spurious IRQs.

Are you missing to disable all IRQs as part of the set-up before
registering the GPIO chip? (Usually some registers need to
be written with zeroes.)

Yours,
Linus Walleij