[PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm

nicolas saenz julienne nsaenz at kernel.org
Thu Sep 30 08:54:43 PDT 2021


On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote:
> In order to access the HDMI controller, we need to make sure the HSM
> clock is enabled. If we were to access it with the clock disabled, the
> CPU would completely hang, resulting in an hard crash.
> 
> Since we have different code path that would require it, let's move that
> clock enable / disable to runtime_pm that will take care of the
> reference counting for us.
> 
> Since we also want to change the HSM clock rate and it's only valid
> while the clock is disabled, we need to move the clk_set_min_rate() call
> on the HSM clock above pm_runtime_get_and_sync().
> 
> Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver")
> Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> Reviewed-by: Dave Stevenson <dave.stevenson at raspberrypi.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz at kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz at kernel.org>

Regards,
Nicolas




More information about the linux-arm-kernel mailing list