[PATCH v17 10/15] arm64: kexec: use ld script for relocation function
Pasha Tatashin
pasha.tatashin at soleen.com
Wed Sep 29 21:08:17 PDT 2021
Sorry, missed two comments:
> > /* Flush the reloc_code in preparation for its execution. */
> > dcache_clean_inval_poc((unsigned long)reloc_code,
> > - (unsigned long)reloc_code +
> > - arm64_relocate_new_kernel_size);
> > + (unsigned long)reloc_code + reloc_size);
>
> Extra whitespace.
Yeap, extra whitespace after '+', will fix it :)
>
> > icache_inval_pou((uintptr_t)reloc_code,
> > - (uintptr_t)reloc_code +
> > - arm64_relocate_new_kernel_size);
> > + (uintptr_t)reloc_code + reloc_size);
> > kexec_list_flush(kimage);
> > kexec_image_info(kimage);
> >
> > diff --git a/arch/arm64/kernel/relocate_kernel.S b/arch/arm64/kernel/relocate_kernel.S
> > index b4fb97312a80..9d2400855ee4 100644
> > --- a/arch/arm64/kernel/relocate_kernel.S
> > +++ b/arch/arm64/kernel/relocate_kernel.S
> > @@ -15,6 +15,7 @@
> > #include <asm/sysreg.h>
> > #include <asm/virt.h>
> >
> > +.pushsection ".kexec_relocate.text", "ax"
>
> Just use .section if you're putting the entire file in there?
Good point, I will change it to .section.
More information about the linux-arm-kernel
mailing list