[PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers

nicolas saenz julienne nsaenz at kernel.org
Tue Sep 28 09:26:55 PDT 2021


On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote:
> The driver, once it found a divider, tries to round it up by increasing
> the least significant bit of the fractional part by one when the
> round_up argument is set and there's a remainder.
> 
> However, since it increases the divider it will actually reduce the
> clock rate below what we were asking for, leading to issues with
> clk_set_min_rate() that will complain that our rounded clock rate is
> below the minimum of the rate.
> 
> Since the dividers are fairly precise already, let's remove that part so
> that we can have clk_set_min_rate() working.
> 
> This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round
> up ability to the clock divisor").
> 
> Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock divisor")
> Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz at kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz at kernel.org> # boot and basic functionality

Regards,
Nicolas




More information about the linux-arm-kernel mailing list