[PATCH] PCI: xgene: Use PCI_VENDOR_ID_AMCC macro
Krzysztof Wilczyński
kw at linux.com
Mon Sep 27 15:01:09 PDT 2021
Hi Pali,
> Header file linux/pci_ids.h defines AMCC vendor id (0x10e8) macro named
> PCI_VENDOR_ID_AMCC. So use this macro instead of driver custom macro.
[...]
> -#define XGENE_PCIE_VENDORID 0x10E8
Another possible way of doing this might have been to alias the macro:
#define XGENE_PCIE_VENDORID PCI_VENDOR_ID_AMCC
Not sure if this would be more or less confusing - I certainly had to go
and look up what "AMCC" was. Only to found out they got sold few years
ago, and such...
Nothing to change here, though.
> #define XGENE_PCIE_DEVICEID 0xE004
> #define SZ_1T (SZ_1G*1024ULL)
> #define PIPE_PHY_RATE_RD(src) ((0xc000 & (u32)(src)) >> 0xe)
> @@ -560,7 +559,7 @@ static int xgene_pcie_setup(struct xgene_pcie_port *port)
> xgene_pcie_clear_config(port);
>
> /* setup the vendor and device IDs correctly */
> - val = (XGENE_PCIE_DEVICEID << 16) | XGENE_PCIE_VENDORID;
> + val = (XGENE_PCIE_DEVICEID << 16) | PCI_VENDOR_ID_AMCC;
> xgene_pcie_writel(port, BRIDGE_CFG_0, val);
Thank you!
Reviewed-by: Krzysztof Wilczyński <kw at linux.com>
Krzysztof
More information about the linux-arm-kernel
mailing list