[PATCH] cpufreq: s3c244x: add fallthrough comments for switch
Krzysztof Kozlowski
krzysztof.kozlowski at canonical.com
Mon Sep 27 02:55:57 PDT 2021
On 27/09/2021 11:51, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
>
> Apparently nobody has so far caught this warning, I hit it in randconfig
> build testing:
>
> drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs':
> drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here
> case 3:
> ^~~~
> drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
> camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
> ^
> drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here
> case 4:
> ^~~~
>
> Both look like the fallthrough is intentional, so add the new
> "fallthrough;" keyword.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
> drivers/cpufreq/s3c2440-cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
I think I saw it but back then implicit-fallthrough was not an error :)
LGTM:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list