NAK: [PATCH] HID: thrustmaster: Initialized pointer twi with NULL rather than 0

Colin Ian King colin.king at canonical.com
Sat Sep 25 15:26:21 PDT 2021


On 25/09/2021 23:22, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Pointers should be initialized with NULL rather than 0. Fix this.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  drivers/hid/hid-thrustmaster.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
> index d44550aa8805..aa874f075bf9 100644
> --- a/drivers/hid/hid-thrustmaster.c
> +++ b/drivers/hid/hid-thrustmaster.c
> @@ -205,7 +205,7 @@ static void thrustmaster_model_handler(struct urb *urb)
>  	struct tm_wheel *tm_wheel = hid_get_drvdata(hdev);
>  	uint16_t model = 0;
>  	int i, ret;
> -	const struct tm_wheel_info *twi = 0;
> +	const struct tm_wheel_info *twi = NULL;
>  
>  	if (urb->status) {
>  		hid_err(hdev, "URB to get model id failed with error %d\n", urb->status);
> 

NACK, I spotted another pointer than needs the same change, will send a V2.



More information about the linux-arm-kernel mailing list