[PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault()

Arnd Bergmann arnd at arndb.de
Tue Sep 21 03:39:38 PDT 2021


On Tue, Sep 21, 2021 at 11:53 AM Ard Biesheuvel <ardb at kernel.org> wrote:
>
> Commit 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead
> of set_fs()") replaced an occurrence of __get_user() with
> get_kernel_nofault(), but inverted the sense of the conditional in the
> process, resulting in no values to be printed at all.
>
> I.e., every exception stack now looks like this:
>
> Exception stack(0xc18d1fb0 to 0xc18d1ff8)
> 1fa0:                                     ???????? ???????? ???????? ????????
> 1fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
> 1fe0: ???????? ???????? ???????? ???????? ???????? ????????
>
> which is rather unhelpful.
>
> Fixes: 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()")
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>

Thanks for catching this!

Reviewed-by: Arnd Bergmann <arnd at arndb.de>



More information about the linux-arm-kernel mailing list