[PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example
Suman Anna
s-anna at ti.com
Mon Sep 20 13:57:49 PDT 2021
On 9/20/21 7:31 AM, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja at ti.com>
>
> The example includes a board-specific compatible property, this is wrong
> as the example should be board agnostic and should represent the particular
> binding. Also, the file includes two similar examples but with a different
> compatible. So, drop the entire second example
>
> Suggested-by: Bjorn Andersson <bjorn.andersson at linaro.org>
> Signed-off-by: Sinthu Raja <sinthu.raja at ti.com>
Acked-by: Suman Anna <s-anna at ti.com>
>
> ---
>
> Changes in V3:
> Addressed review comment, that includes adding Suggested By: tag to the
> commit message
>
> V2: https://lore.kernel.org/all/20210917170805.5079-1-sinthu.raja@ti.com/
> V1: https://lore.kernel.org/all/20210917094740.18891-1-sinthu.raja@ti.com/
>
> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 33 +------------------
> 1 file changed, 1 insertion(+), 32 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> index ae1b37dbee75..0a955c7b9706 100644
> --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> @@ -39,39 +39,8 @@ additionalProperties: false
> examples:
>
> - |
> - /* OMAP4 SoCs */
> - hwspinlock: spinlock at 4a0f6000 {
> + spinlock at 4a0f6000 {
> compatible = "ti,omap4-hwspinlock";
> reg = <0x4a0f6000 0x1000>;
> #hwlock-cells = <1>;
> };
> -
> - - |
> - / {
> - /* K3 AM65x SoCs */
> - model = "Texas Instruments K3 AM654 SoC";
> - compatible = "ti,am654-evm", "ti,am654";
> - #address-cells = <2>;
> - #size-cells = <2>;
> -
> - bus at 100000 {
> - compatible = "simple-bus";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
> - <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>; /* Main NavSS */
> -
> - bus at 30800000 {
> - compatible = "simple-mfd";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges = <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>;
> -
> - spinlock at 30e00000 {
> - compatible = "ti,am654-hwspinlock";
> - reg = <0x00 0x30e00000 0x00 0x1000>;
> - #hwlock-cells = <1>;
> - };
> - };
> - };
> - };
>
More information about the linux-arm-kernel
mailing list