[PATCH 4/4] pata_imx: deny IRQ0

Fabio Estevam festevam at gmail.com
Mon Sep 20 05:45:03 PDT 2021


Hi Sergey,

On Sat, Sep 18, 2021 at 5:49 PM Sergey Shtylyov <s.shtylyov at omp.ru> wrote:

> > IMHO the current code is correct as-is.
>
>    Not quite... I don't want to leave a bad example for the future driver authors. What should
> I change in the patch description for the patch to become acceptable for you?

Please see how the PCI subsystem has converted the handling of
platform_get_irq():
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5

Why does drivers/ata/ need to handle platform_get_irq() differently?

I still don't see the need for changing drivers/ata/pata_imx.c in this aspect.



More information about the linux-arm-kernel mailing list