[PATCH] ARM: s3c: Use strscpy to replace strlcpy
Krzysztof Kozlowski
krzysztof.kozlowski at canonical.com
Mon Sep 20 01:15:04 PDT 2021
On Mon, 6 Sep 2021 21:46:56 +0800, Jason Wang wrote:
> The strlcpy should not be used because it doesn't limit the source
> length. As linus says, it's a completely useless function if you
> can't implicitly trust the source string - but that is almost always
> why people think they should use it! All in all the BSD function
> will lead some potential bugs.
>
> But the strscpy doesn't require reading memory from the src string
> beyond the specified "count" bytes, and since the return value is
> easier to error-check than strlcpy()'s. In addition, the implementation
> is robust to the string changing out from underneath it, unlike the
> current strlcpy() implementation.
>
> [...]
Applied, thanks!
[1/1] ARM: s3c: Use strscpy to replace strlcpy
commit: aa519471715ce73034ffaa52fc85681de31c1acf
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
More information about the linux-arm-kernel
mailing list