[PATCH] ARM: dts: Fix Ethernet support

[Russell King (Oracle)]

On Tue, Sep 14, 2021 at 11:49:46AM -0300, Fabio Estevam wrote:
> Currently, it is no longer possible to retrieve a DHCP address
> on the imx6qdl-pico board.
> 
> This issue has been exposed by commit f5d9aa79dfdf ("ARM: imx6q:
> remove clk-out fixup for the Atheros AR8031 and AR8035 PHYs").
> 
> Fix it by describing the qca,clk-out-frequency property as suggested
> by the commit above.
> 
> Fixes: 98670a0bb0ef14bbb3 ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-pico.dtsi | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-pico.dtsi b/arch/arm/boot/dts/imx6qdl-pico.dtsi
> index 5de4ccb97916..0a55e1e583ae 100644
> --- a/arch/arm/boot/dts/imx6qdl-pico.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-pico.dtsi
> @@ -175,8 +175,19 @@ &fec {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet>;
>  	phy-mode = "rgmii-id";
> -	phy-reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		phy: ethernet-phy at 1 {
> +			reg = <1>;
> +			qca,clk-out-frequency = <125000000>;
> +			reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <10000>;
> +		};
> +	};
>  };
>  
>  &hdmi {

Do you really want to move the reset properties? Have you tested kexec?

Moving the reset into the phy node without a compatible risks not being
able to read the PHY ID and not being able to detect the presence of
the PHY.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!