[PATCH] firmware: arm_scmi: fix build failure if ARM_SCMI_PROTOCOL=y VIRTIO=m
Cristian Marussi
cristian.marussi at arm.com
Mon Sep 13 01:55:01 PDT 2021
On Sun, Sep 12, 2021 at 11:27:25PM +0200, Adam Borowski wrote:
> A "bool" for a subfeature doesn't force the dependency by itself.
>
> Signed-off-by: Adam Borowski <kilobyte at angband.pl>
> ---
Hi Adam,
thanks for this fix, BUT it was already spotted by LKP
https://lore.kernel.org/linux-mm/202108151230.lcHk2Pkk-lkp@intel.com/
and a proposed fix is already queued on sudeep/for-next/scmi.
https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/commit/?h=for-next/scmi&id=7b4262378924a9985bc4c35ea015bd48dfe57792
I supposed it will picked up with the next 5.15 scmi fixes.
Probably the original distribution list was a bit odd since I replied to
the above original LKP mail recipients, apologies for this.
Thanks,
Cristian
> drivers/firmware/arm_scmi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig
> index 7f4d2435503b..cca557bc625b 100644
> --- a/drivers/firmware/arm_scmi/Kconfig
> +++ b/drivers/firmware/arm_scmi/Kconfig
> @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC
>
> config ARM_SCMI_TRANSPORT_VIRTIO
> bool "SCMI transport based on VirtIO"
> - depends on VIRTIO
> + depends on VIRTIO >= ARM_SCMI_PROTOCOL
> select ARM_SCMI_HAVE_TRANSPORT
> select ARM_SCMI_HAVE_MSG
> help
> --
> 2.33.0
>
More information about the linux-arm-kernel
mailing list