[PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
Daniel Palmer
daniel at 0x0f.com
Fri Sep 10 20:18:32 PDT 2021
Hi Romain,
On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier at gmail.com> wrote:
> + - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01
> + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
For anyone wondering why we have two strings here:
The SBC board is made up of a SoM and a board with the connectors.
The SoM could be used standalone so we might as well have a compatible
for it too.
We have some dtsis for the SoM but really those could be built as is
to support someone using the SoM on it's own.
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
For anyone wondering:
The som2d01 can come with an SSD201 (64MB DDR2 integrated) or SSD202D
(128MB DDR3 integrated) and they need different fixed regulators for
the DDR supply.
So we have a common dtsi and then override the regulator in another
layer of dtsi for the SSD202D version.
Thinking about it now I think we can drop common from the file name.
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel at thingy.jp>
> + * Author: Romain Perier <romain.perier at gmail.com>
> + */
> +
> +/ {
> +
Unneeded space.
> + reg_vcc_dram: regulator-vcc-dram {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_dram";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> +};
> +
> +&pm_uart {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> new file mode 100644
> index 000000000000..20b40b711d4f
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel at thingy.jp>
> + * Author: Romain Perier <romain.perier at gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "Wireless Tag IDO-SBC2D06-1VB-22W";
> + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m";
> +
> + leds {
> + compatible = "gpio-leds";
> + sys_led {
> + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> new file mode 100644
> index 000000000000..06567a5219c5
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel at thingy.jp>
> + * Author: Romain Perier <romain.perier at gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "mstar-infinity2m-ssd202d.dtsi"
> +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi"
> +
> +/ {
> + model = "Wireless Tag IDO-SOM2D01 (SSD202D)";
> + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m";
> +
> + aliases {
> + serial0 = &pm_uart;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +®_vcc_dram {
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> +};
> --
> 2.33.0
>
Cheers,
Daniel
More information about the linux-arm-kernel
mailing list