[PATCH] ARM: dts: imx: Fix ECSPI nCS polarity on M53Menlo

Marek Vasut marex at denx.de
Wed Sep 8 15:33:01 PDT 2021


On 9/5/21 2:51 AM, Fabio Estevam wrote:
> [Adding Linus]
> 
> On Sat, Sep 4, 2021 at 9:02 PM Marek Vasut <marex at denx.de> wrote:
>>
>> This board has the nCS lines connected to a CPLD and they are active
>> high. Undo the change from 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI
>> chipselect polarity") for this board, as the previous DT description
>> was correct.
>>
>> Fixes: 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI chipselect polarity")
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Shawn Guo <shawnguo at kernel.org>
>> Cc: Fabio Estevam <festevam at gmail.com>
>> Cc: NXP Linux Team <linux-imx at nxp.com>
>> ---
>>   arch/arm/boot/dts/imx53-m53menlo.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
>> index 4f88e96d81ddb..03c43c1912a7e 100644
>> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
>> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
>> @@ -104,7 +104,7 @@ &clks {
>>   &ecspi2 {
>>          pinctrl-names = "default";
>>          pinctrl-0 = <&pinctrl_ecspi2>;
>> -       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio2 27 GPIO_ACTIVE_LOW>;
>> +       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>;
>>          status = "okay";
>>
>>          spidev at 0 {
> 
> Then you need to pass the 'spi-cs-high' property under the spidev nodes.

Turns out this patch can be dropped altogether.

Please drop this one.



More information about the linux-arm-kernel mailing list