[PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo

Fabio Estevam festevam at gmail.com
Sat Sep 4 17:49:14 PDT 2021


Hi Marek,

On Sat, Sep 4, 2021 at 9:01 PM Marek Vasut <marex at denx.de> wrote:
>
> The MIC2025 switch input signal nEN is active low, describe it as such
> in the DT. The previous change to this regulator polarity was incorrectly
> influenced by broken quirks in gpiolib-of.c, which is now long fixed. So
> fix this regulator polarity setting here once and for all.
>
> Fixes: 3c3601cd6a6d3 ("ARM: dts: imx53: Update USB configuration on M53Menlo")
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Shawn Guo <shawnguo at kernel.org>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: NXP Linux Team <linux-imx at nxp.com>
> ---
>  arch/arm/boot/dts/imx53-m53menlo.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> index 48adcfd32cea9..4f88e96d81ddb 100644
> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> @@ -77,8 +77,7 @@ reg_usbh1_vbus: regulator-usbh1-vbus {
>                 regulator-name = "vbus";
>                 regulator-min-microvolt = <5000000>;
>                 regulator-max-microvolt = <5000000>;
> -               gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> -               enable-active-high;
> +               gpio = <&gpio1 2 0>;

Don't you mean: gpio = <&gpio1 2 GPIO_ACTIVE_LOW> here?



More information about the linux-arm-kernel mailing list