[PATCH v2 0/1] arm64: dts: allwinner: NanoPi R1S H5: Add generic compatible string for I2C EEPROM

Chukun Pan amadeus at jmu.edu.cn
Sun Oct 10 06:50:16 PDT 2021


Hi ChenYu,

> You should add the atmel compatible as a fallback one, not replace the
> microchip one.

Thanks for correcting, I did it, also upgrade the commit message.

> Please also add a cell representing the MAC address, and hook it up
> to the GMAC. You can find an example here [1].

Frankly speaking, I’m a little confused about this. There is a rtl8153
usb network card on this machine, the original factory seems to store
its mac address on this eeprom. It seems that there is no usb network
card written in dts in the kernel before, and the rtl8152 driver may
also need to be modified accordingly to support reading the mac address
from eeprom.

Sorry for my bad English.

Thanks,
Chukun

Changes from v2:
* Typo fixes for the position format.
* Add a nvmem cell representing the MAC address.

Chukun Pan (1):
  arm64: dts: allwinner: NanoPi R1S H5: Add generic compatible string
    for I2C EEPROM

 .../arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.17.1




More information about the linux-arm-kernel mailing list