[PATCH 1/2] irqchip/armada-370-xp: Fix return value of armada_370_xp_msi_alloc()
Marc Zyngier
maz at kernel.org
Thu Nov 25 06:06:21 PST 2021
On Thu, 25 Nov 2021 13:00:56 +0000,
Pali Rohár <pali at kernel.org> wrote:
>
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
>
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Fixes: fcc392d501bd ("irqchip/armada-370-xp: Use the generic MSI infrastructure")
> Cc: stable at vger.kernel.org
> ---
> drivers/irqchip/irq-armada-370-xp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
> index 80906bfec845..41ad745cf343 100644
> --- a/drivers/irqchip/irq-armada-370-xp.c
> +++ b/drivers/irqchip/irq-armada-370-xp.c
> @@ -250,7 +250,7 @@ static int armada_370_xp_msi_alloc(struct irq_domain *domain, unsigned int virq,
> NULL, NULL);
> }
>
> - return hwirq;
> + return 0;
> }
>
> static void armada_370_xp_msi_free(struct irq_domain *domain,
> --
> 2.20.1
>
>
Looks good too. As this lives in the irqchip tree, I'll queue these
two patches directly unless someone shouts...
M.
--
Without deviation from the norm, progress is not possible.
More information about the linux-arm-kernel
mailing list