[PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
Shawn Guo
shawnguo at kernel.org
Sun Nov 21 17:23:38 PST 2021
On Thu, Nov 18, 2021 at 06:59:34AM -0300, Fabio Estevam wrote:
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> have the ESAI_TX0 functionality, not ESAI_T0.
>
> Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
>
> Add an entry for the correct name and still keep the old one to
> avoid potential breakage.
>
> Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
> Reported-by: George Makarov <georgemakarov1 at gmail.com>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
> arch/arm/boot/dts/imx6ull-pinfunc.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ull-pinfunc.h b/arch/arm/boot/dts/imx6ull-pinfunc.h
> index eb025a9d4759..b492164e8cfb 100644
> --- a/arch/arm/boot/dts/imx6ull-pinfunc.h
> +++ b/arch/arm/boot/dts/imx6ull-pinfunc.h
> @@ -82,6 +82,11 @@
> #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0
> #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0
> #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0
> +/*
> + * As per the Reference Manual the correct name is ESAI_TX0.
> + * Keep the old name here to avoid breakage.
> + */
> #define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0
I don't see any user of it, so should be be safe just to remove it, no?
Shawn
> +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0
>
> #endif /* __DTS_IMX6ULL_PINFUNC_H */
> --
> 2.25.1
>
More information about the linux-arm-kernel
mailing list