[PATCH v3 05/13] peci: Add peci-aspeed controller driver

[Govert Overgaauw]

On 15-11-2021 19:25, Iwona Winiarska wrote
> >+       if (ret == 0) {
> >+               dev_dbg(priv->dev, "Timeout waiting for a response!\n");
> >+               return -ETIMEDOUT;
> >+       }
> >+
> >+       spin_lock_irq(&priv->lock);
> >+
> >+       writel(0, priv->base + ASPEED_PECI_CMD);

Shouldn't writel(0, priv->base + ASPEED_PECI_CMD) move to above the 
Timeout error return. I have been testing this patch on our platform and 
noticed that no transfer would be started if the ASPEED_PECI_CMD_FIRE 
bit is already set. In case of a timeout it is never cleared, resulting 
in timeouts on all future calls.