[PATCH] soc: ti: Use DEFINE_DEBUGFS_ATTRIBUTE
Vihas Mak
makvihas at gmail.com
Wed Nov 10 11:17:07 PST 2021
Use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE as
pm_sr_fops is used to create a debugfs file.
This solves following warning generated by coccicheck:
./drivers/soc/ti/smartreflex.c:815:0-23: WARNING: pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Signed-off-by: Vihas Mak <makvihas at gmail.com>
---
drivers/soc/ti/smartreflex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
index b5b2fa538..14b69307d 100644
--- a/drivers/soc/ti/smartreflex.c
+++ b/drivers/soc/ti/smartreflex.c
@@ -812,7 +812,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
+DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
omap_sr_autocomp_store, "%llu\n");
static int omap_sr_probe(struct platform_device *pdev)
--
2.25.1
More information about the linux-arm-kernel
mailing list