[PATCH 0/2] pwm: vt8500: Implement .apply() callback

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Nov 2 02:28:02 PDT 2021


Hello,

this series implements .apply for the vt8500 pwm driver and fixes a
function name that I stumbled over while doing that.

One thing that could be improved (but probably only with hardware
available which I don't have) is:

 - vt8500_pwm_apply() calls the old callbacks now, it might be possible
   to improve clk handling such that the clk is at most once enabled and
   once disabled.

 - .probe() doesn't handle the PWM already being on.

 - There is no .get_state() callback.

Best regards
Uwe

Uwe Kleine-König (2):
  pwm: vt8500: Implement .apply() callback
  pwm: vt8500: Rename pwm_busy_wait() to make it obviously
    driver-specific

 drivers/pwm/pwm-vt8500.c | 73 +++++++++++++++++++++++++++++++---------
 1 file changed, 58 insertions(+), 15 deletions(-)


base-commit: 8bb7eca972ad531c9b149c0a51ab43a417385813
-- 
2.30.2




More information about the linux-arm-kernel mailing list