[PATCH 2/3] watchdog: Add Mstar MSC313e WDT driver

[Guenter Roeck]

On 5/25/21 11:49 AM, Randy Dunlap wrote:
> Hi,
> 
> On 5/25/21 11:44 AM, Romain Perier wrote:
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 355100dad60a..f53634ea0de6 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -980,6 +980,19 @@ config VISCONTI_WATCHDOG
>>   	  Say Y here to include support for the watchdog timer in Toshiba
>>   	  Visconti SoCs.
>>   
>> +config MSC313E_WATCHDOG
>> +	tristate "MStar MSC313e watchdog"
>> +	depends on ARCH_MSTARV7 || COMPILE_TEST
>> +	depends on OF
>> +	select WATCHDOG_CORE
>> +	help
>> +	  Say Y here to include support for the Watchdog timer embedded
>> +	  into MStar MSC313e chips. This will reboot your system when the
>> +	  timeout is reached.
>> +
>> +	  To compile this driver as a module, choose M here: the
>> +	  module will be called msc313e_wdt.
> 
> AFAIK, you don't need the "depends on OF" line since
> the of*.h headers provide stubs for the cases of CONFIG_OF
> and/or CONFIG_OF_ADDRESS not set/enabled.
> 

I don't actually see any devicetree API calls in the driver.

Guenter

> Not having that line would also make COMPILE_TEST more effective.
> 
> Can Rob or anyone else comment on this?
> 
> thanks.
>