[PATCH 2/3 v2] crypto: ixp4xx: Add DT bindings

Rob Herring robh at kernel.org
Mon May 24 06:47:39 PDT 2021


On Sat, May 22, 2021 at 11:26 AM Linus Walleij <linus.walleij at linaro.org> wrote:
>
> On Fri, May 21, 2021 at 7:27 PM Rob Herring <robh at kernel.org> wrote:
>
> > > +  intel,npe:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    minimum: 0
> > > +    maximum: 3
> > > +    description: phandle to the NPE this ethernet instance is using
> >
> > Not a phandle now.
> >
> > > +      and the instance to use in the second cell
> >
> > Maybe 'reg' works here? You can only have 1 thing you address though if
> > you use reg here.
>
> Good idea, I'll try that.
>
> > How are other NPE instances used? Are you going to need to have a
> > reference to them?
>
> They are used by phandle from the combined ethernet and phy
> instances.

So 'intel,npe' property? Then we should probably just keep that. For
sure, we don't want a given property to have 2 different types. (Some
day I intend to check for that.)

> They are accelerators with firmware which have direct
> access to the ethernet and phy port, and one of the NPE:s can
> additionally contain a crypto engine.



More information about the linux-arm-kernel mailing list