[boot-wrapper PATCH v2 3/8] aarch64: Remove the redundant setup_stack

Andre Przywara andre.przywara at arm.com
Mon May 24 02:32:39 PDT 2021


On Fri, 21 May 2021 18:48:02 +0800
Jaxson Han <jaxson.han at arm.com> wrote:

> Since we already have set up a stack above, there is no need to do it
> again.

Indeed, in fact it's a bug: setup_stack expects the logical CPU ID in
w0, and here we always call it with w0 being 1.

> Signed-off-by: Jaxson Han <jaxson.han at arm.com>

Reviewed-by: Andre Przywara <andre.przywara at arm.com>

Thanks!
Andre

> ---
>  arch/aarch64/boot.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S
> index e4f5f3d..ee9886b 100644
> --- a/arch/aarch64/boot.S
> +++ b/arch/aarch64/boot.S
> @@ -39,7 +39,6 @@ _start:
>  	ldr	x1, =flag_keep_el
>  	str	w0, [x1]
>  
> -	bl	setup_stack
>  	b	start_keep_el
>  
>  	/*




More information about the linux-arm-kernel mailing list