[PATCH v3 5/7] crypto: arm64/aes-neonbs - stop using SIMD helper for skciphers

Ard Biesheuvel ardb at kernel.org
Wed May 12 14:25:16 PDT 2021


On Wed, 12 May 2021 at 22:08, Eric Biggers <ebiggers at kernel.org> wrote:
>
> On Wed, May 12, 2021 at 08:44:37PM +0200, Ard Biesheuvel wrote:
> > Calls into the skcipher API can only occur from contexts where the SIMD
> > unit is available, so there is no need for the SIMD helper.
> >
> > Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
>
> It would be helpful if the commit message made it clear that "Calls into the
> skcipher API can only occur from contexts where the SIMD unit is available" is
> something that is now the case but wasn't the case previously.  Otherwise I
> could see people backporting this patch without its prerequisites.
>
> Likewise for some of the other patches in this patchset.
>

OK



More information about the linux-arm-kernel mailing list