[PATCH 1/1] irqchip/irq-mvebu-icu: Remove redundant error printing in mvebu_icu_probe()

Leizhen (ThunderTown) thunder.leizhen at huawei.com
Wed May 12 05:23:58 PDT 2021



On 2021/5/11 20:11, Leizhen (ThunderTown) wrote:
> 
> 
> On 2021/5/11 20:08, Marc Zyngier wrote:
>> Hi Zhen,
>>
>> On 2021-05-11 13:01, Zhen Lei wrote:
>>> When devm_ioremap_resource() fails, a clear enough error message will be
>>> printed by its subfunction __devm_ioremap_resource(). The error
>>> information contains the device name, failure cause, and possibly resource
>>> information.
>>>
>>> Therefore, remove the error printing here to simplify code and reduce the
>>> binary size.
>>>
>>> Reported-by: Hulk Robot <hulkci at huawei.com>
>>> Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
>>
>> I'm all grateful for these changes, but can you please organise them
>> in a series and send all the irqchip-related changes at once, instead
>> of one patch every two hours?

In a hurry yesterday, I misunderstood that they needed to be merged into one patch.
Because the rbot reports only one file at a time and there is no file order. I didn't
take the time to summarise it at first.


> 
> OK, I will do it.
> 
>>
>> Thanks,
>>
>>         M.




More information about the linux-arm-kernel mailing list