#regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

[Tony Lindgren]

* Naresh Kamboju <naresh.kamboju at linaro.org> [210506 15:19]:
> On Thu, 6 May 2021 at 17:23, Tony Lindgren <tony at atomide.com> wrote:
> >
> > Hi,
> >
> > * Naresh Kamboju <naresh.kamboju at linaro.org> [210506 11:00]:
> > > Our bisect script pointed this as the first bad commit on linux
> > > mainline master branch.
> > >
> > > Full test log:
> > > ----------------
> > > SATA detection failed log link,
> > > https://lkft.validation.linaro.org/scheduler/job/2580998#L1973
> > >
> > > --
> > > commit 98feab31ac491400f28b76a04dabd18ce21e91ba
> > > Author: Tony Lindgren <tony at atomide.com>
> > > Date:   Wed Mar 10 14:03:51 2021 +0200
> > >
> > >     ARM: OMAP2+: Drop legacy platform data for dra7 sata
> >
> > Thanks for the report, looks like we are now missing the sata related
> > quirk flags compared to the patch above.
> >
> > Below is a quick patch to add the missing quirk flags that might help
> > if you can give it a try.
> 
> The reported problem was solved by this patch. Thank you.
> Please add reported and tested by tags.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju at linaro.org>
> Tested-by: Naresh Kamboju <naresh.kamboju at linaro.org>

OK good to hear and thanks for testing. Will send out a proper patch.

Regards,

Tony

> > 8< --------------------------
> > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> > --- a/drivers/bus/ti-sysc.c
> > +++ b/drivers/bus/ti-sysc.c
> > @@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
> >                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> >         SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff,
> >                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> > +       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff,
> > +                  SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> >         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff,
> >                    SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY),
> >         SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff,
> > @@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
> >         SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0),
> >         SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
> >         SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0),
> > -       SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0),
> >         SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0),
> >         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0),
> >         SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0),
> > --
> > 2.31.1
> 
> 
> Tested full log,
> https://lkft.validation.linaro.org/scheduler/job/2641881#L1940
> 
> - Naresh