[PATCH v9 00/33] Introduce the Counter character device interface
William Breathitt Gray
vilhelm.gray at gmail.com
Tue Mar 9 13:19:13 GMT 2021
Changes in v9:
- Implemented example userspace counter application under tools/counter
- Replaced extension*_name attributes with *_component_id attributes;
this should hopefully be a more intuitive way to find the desired IDs
- Changed to use regular spinlock because raw_spinlock is not needed
- Implemented chrdev_lock mutex to limit chrdev to a single open() at a
time
- Improved struct counter_component documentation with examples
- Reverted "counter_count_function" to "counter_function" naming change
for drivers; individual maintainers can change this if they so desire
- Utilized "return 0" in switch blocks to return early where possible
- Utilized default cases in switch blocks to improve clarity and intent
- Refactored counter_register to make use of cdev_add_device();
counter_chrdev_add() has been simplified as a result
- Inlined counter_chrdev_realloc_queue() because it is only used by the
events_queue_size sysfs attribute
- Replaced deprecated ida_simple_* calls with ida_alloc()/ida_free()
- Made use of struct device "id" member to construct the cdev node name
- Made use of kfifo_size() instead of rolling my own
- Implemented changes necessary to migrate interrupt-cnt driver
Note that this revision is based on top of 5 prerequisite patches:
* counter: add IRQ or GPIO based counter
* dt-bindings: counter: add interrupt-counter binding
* counter: stm32-timer-cnt: fix ceiling miss-alignment with reload register
* counter: stm32-timer-cnt: fix ceiling write max value
* counter: stm32-timer-cnt: Report count function when SLAVE_MODE_DISABLED
I pulled out a lot of bits and pieces to their own patches; hopefully
that makes reviewing this patchset much simpler than before. This
patchset is also available on my personal public git repo for anyone who
wants a quick way to clone:
https://gitlab.com/vilhelmgray/iio/-/tree/counter_chrdev_v9
The patches preceding "counter: Internalize sysfs interface code" are
primarily cleanup and fixes that can be picked up and applied now to the
IIO tree if so desired. The "counter: Internalize sysfs interface code"
patch as well may be considered for pickup because it is relatively safe
and makes no changes to the userspace interface.
To summarize the main points of this patchset: there are no changes to
the existing Counter sysfs userspace interface; a Counter character
device interface is introduced that allows Counter events and associated
data to be read() by userspace; the events_configure() and
watch_validate() driver callbacks are introduced to support Counter
events; and IRQ support is added to the 104-QUAD-8 driver, serving as an
example of how to support the new Counter events functionality.
Something that should still be discussed: should the struct
counter_event "status" member be 8 bits or 32 bits wide? This member
will provide the return status (system error number) of an event
operation.
William Breathitt Gray (33):
docs: counter: Consolidate Counter sysfs attributes documentation
docs: counter: Fix spelling
counter: 104-quad-8: Remove pointless comment
counter: 104-quad-8: Return error when invalid mode during
ceiling_write
counter: 104-quad-8: Annotate hardware config module parameter
counter: 104-quad-8: Add const qualifiers for
quad8_preset_register_set
counter: 104-quad-8: Add const qualifier for functions_list array
counter: interrupt-cnt: Add const qualifier for functions_list array
counter: microchip-tcb-capture: Add const qualifier for functions_list
array
counter: stm32-lptimer-cnt: Add const qualifier for functions_list
array
counter: stm32-timer-cnt: Add const qualifier for functions_list array
counter: 104-quad-8: Add const qualifier for actions_list array
counter: ftm-quaddec: Add const qualifier for actions_list array
counter: interrupt-cnt: Add const qualifier for actions_list array
counter: microchip-tcb-capture: Add const qualifier for actions_list
array
counter: stm32-lptimer-cnt: Add const qualifier for actions_list array
counter: stm32-timer-cnt: Add const qualifier for actions_list array
counter: Return error code on invalid modes
counter: Standardize to ERANGE for limit exceeded errors
counter: Rename counter_signal_value to counter_signal_level
counter: Rename counter_count_function to counter_function
counter: Internalize sysfs interface code
counter: Update counter.h comments to reflect sysfs internalization
docs: counter: Update to reflect sysfs internalization
counter: Move counter enums to uapi header
counter: Add character device interface
docs: counter: Document character device interface
tools/counter: Create Counter tools
counter: Implement signalZ_action_component_id sysfs attribute
counter: Implement *_component_id sysfs attributes
counter: Implement events_queue_size sysfs attribute
counter: 104-quad-8: Replace mutex with spinlock
counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8
Documentation/ABI/testing/sysfs-bus-counter | 112 +-
.../ABI/testing/sysfs-bus-counter-104-quad-8 | 61 -
.../ABI/testing/sysfs-bus-counter-ftm-quaddec | 16 -
Documentation/driver-api/generic-counter.rst | 368 +++-
.../userspace-api/ioctl/ioctl-number.rst | 1 +
MAINTAINERS | 7 +-
drivers/counter/104-quad-8.c | 739 ++++----
drivers/counter/Kconfig | 6 +-
drivers/counter/Makefile | 1 +
drivers/counter/counter-chrdev.c | 486 ++++++
drivers/counter/counter-chrdev.h | 14 +
drivers/counter/counter-core.c | 192 +++
drivers/counter/counter-sysfs.c | 953 +++++++++++
drivers/counter/counter-sysfs.h | 13 +
drivers/counter/counter.c | 1496 -----------------
drivers/counter/ftm-quaddec.c | 61 +-
drivers/counter/interrupt-cnt.c | 75 +-
drivers/counter/microchip-tcb-capture.c | 105 +-
drivers/counter/stm32-lptimer-cnt.c | 176 +-
drivers/counter/stm32-timer-cnt.c | 149 +-
drivers/counter/ti-eqep.c | 221 +--
include/linux/counter.h | 716 ++++----
include/linux/counter_enum.h | 45 -
include/uapi/linux/counter.h | 133 ++
tools/Makefile | 13 +-
tools/counter/Build | 1 +
tools/counter/Makefile | 53 +
tools/counter/counter_example.c | 95 ++
28 files changed, 3522 insertions(+), 2786 deletions(-)
delete mode 100644 Documentation/ABI/testing/sysfs-bus-counter-104-quad-8
delete mode 100644 Documentation/ABI/testing/sysfs-bus-counter-ftm-quaddec
create mode 100644 drivers/counter/counter-chrdev.c
create mode 100644 drivers/counter/counter-chrdev.h
create mode 100644 drivers/counter/counter-core.c
create mode 100644 drivers/counter/counter-sysfs.c
create mode 100644 drivers/counter/counter-sysfs.h
delete mode 100644 drivers/counter/counter.c
delete mode 100644 include/linux/counter_enum.h
create mode 100644 include/uapi/linux/counter.h
create mode 100644 tools/counter/Build
create mode 100644 tools/counter/Makefile
create mode 100644 tools/counter/counter_example.c
base-commit: 4ef57c4862e38e6034978d8b247a511292d7055a
prerequisite-patch-id: 41fda3a386861edad110c644567fad373a5a175e
prerequisite-patch-id: c6c2ab3173f5a0136d1e9b7b96ccd115fa35d66e
prerequisite-patch-id: 7e3cd78924d79890b690f3029e0d4f5b3902a73c
prerequisite-patch-id: 98f0a6c1d188a7dec01a5587fb7566ac637385a1
prerequisite-patch-id: 884299e23b6426ea43282e9701996e794cb6aa34
--
2.30.1
More information about the linux-arm-kernel
mailing list