[PATCH] iommu/arm: Cleanup resources in case of probe error path

Krishna Reddy vdumpa at nvidia.com
Wed Jun 30 17:13:04 PDT 2021


> +
> +err_pm_disable:
> +       pm_runtime_disable(dev);
>          return ret;
>   }

Should it be pm_runtime_force_suspend()?  qcom_iommu_device_remove() doesn't use pm_runtime_disable(dev).

875 static int qcom_iommu_device_remove(struct platform_device *pdev)
876 {
...
881 >-------pm_runtime_force_suspend(&pdev->dev);
882 >-------platform_set_drvdata(pdev, NULL);
883 >-------iommu_device_sysfs_remove(&qcom_iommu->iommu);
884 >-------iommu_device_unregister(&qcom_iommu->iommu);
...
887 }

-KR



More information about the linux-arm-kernel mailing list