[PATCH V4 06/15] ARM: dts: imx6q-dhcom: Add keys and leds to the PDK2 board

[Christoph Niedermaier]

From: Marek Vasut [mailto:marex at denx.de]
Sent: Tuesday, June 29, 2021 5:10 PM
> On 6/29/21 3:56 PM, Christoph Niedermaier wrote:
> 
> [...]
> 
>> diff --git a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
>> index 6bb7129d0498..ff794a77c5db 100644
>> --- a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
>> +++ b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
> 
> [...]
> 
>> +     led {
>> +             compatible = "gpio-leds";
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&pinctrl_leds_pdk2>;
>> +
>> +             /*
>> +              * Disable led-5, because GPIO E is
>> +              * already used as touch interrupt.
>> +              */
>> +             led-5 {
>> +                     color = <LED_COLOR_ID_GREEN>;
>> +                     function = LED_FUNCTION_INDICATOR;
>> +                     gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; /* GPIO E */
>> +                     default-state = "off";
>> +                     status = "disabled";
>> +             };
> 
> [...]
> 
>> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> index c5c060c6b9bf..68ac29d28f4f 100644
>> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> @@ -9,6 +9,7 @@
>>   #include <dt-bindings/gpio/gpio.h>
>>   #include <dt-bindings/clock/imx6qdl-clock.h>
>>   #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
> 
> The LEDs are optionally present on some of the carrier boards, so this
> header should be included in the carrier board .dts file I think.

Thanks, will fix this in version 5.

Regards
Christoph