[PATCH] mmc: Prefer unsigned int to bare use of unsigned

Michał Mirosław mirq-linux at rere.qmqm.pl
Sat Jun 26 14:28:02 PDT 2021


On Sat, Jun 26, 2021 at 04:36:57PM +0800, Jinchao Wang wrote:
> Fix checkpatch warnings:
>     WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
[...]
>  int mmc_send_adtc_data(struct mmc_card *card, struct mmc_host *host, u32 opcode,
> -		       u32 args, void *buf, unsigned len)
> +		       u32 args, void *buf, unsigned int len)

I'd suggest size_t for the 'size' and 'len' arguments while at it.

> --- a/drivers/mmc/host/cb710-mmc.c
[...]

For cb710 part:

Acked-by: Michał Mirosław <mirq-linux at rere.qmqm.pl>

BTW, I think you should directly Cc: driver maintainers with each driver
having its separate patch. I noticed code for cb710 in this patch purely
by chance.

Best Regards
Michał Mirosław



More information about the linux-arm-kernel mailing list